Requesting reviews on php-src pull requests

  117843
May 31, 2022 21:53 Ben Ramsey <ramsey@php.net>
--------------5B4dG9Q95NjpB6bvWTSB00s7
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

VGhpcyBjYW1lIHVwIGluIGEgY29udmVyc2F0aW9uIEkgaGFkIHdpdGggU2VyZ2V5IGFuZCBQ
aWVycmljayBlYXJsaWVyIA0KdG9kYXkuLi4NCg0KQXMgcmVsZWFzZSBtYW5hZ2VycyBnbyB0
aHJvdWdoIG9wZW4gUFJzLCB3ZSB0YWcgdGhlbSB3aXRoICJXYWl0aW5nIG9uIA0KUmV2aWV3
IiB0byBpbmRpY2F0ZSB0byBvdGhlciBpbnRlcm5hbHMgZGV2cyB0aGF0IGEgUFIgbmVlZHMg
cmV2aWV3Lg0KDQpJbiBmYWN0LCB3ZSBoYXZlIHF1aXRlIGEgZmV3IHRoYXQgYXJlIGN1cnJl
bnRseSB3YWl0aW5nIG9uIHJldmlldzoNCg0KaHR0cHM6Ly9naXRodWIuY29tL3BocC9waHAt
c3JjL3B1bGxzP3E9aXMlM0FvcGVuK2lzJTNBcHIrbGFiZWwlM0ElMjJXYWl0aW5nK29uK1Jl
dmlldyUyMg0KDQpVbmZvcnR1bmF0ZWx5LCB3ZSBkb24ndCBhbHdheXMga25vdyB3aG8gaXMg
dGhlIGJlc3QgcGVyc29uIHRvIHJldmlldyBhIA0KUFIsIHNvIHdlIGhvcGUgdGhhdCBvdGhl
cnMgYXJlIGNoZWNraW5nIHRvIHNlZSB3aGV0aGVyIHRoZXJlIGFyZSBQUnMgDQp0aGF0IG5l
ZWQgcmV2aWV3cyBpbiB0aGVpciBhcmVhIG9mIGV4cGVydGlzZS4NCg0KSXQgd291bGQgYmUg
aGVscGZ1bCB0byBrbm93IGZyb20gd2hvbSB3ZSBzaG91bGQgcmVxdWVzdCByZXZpZXdzLCBi
YXNlZCANCm9uIHRoZSBhcmVhIG9mIHRoZSBjb2RlIChpLmUuLCBleHQsIFplbmQsIG1haW4s
IGV0Yy4pLiBPbmUgd2F5IGlzIHRvIHNldCANCnVwIGEgdGFibGUgb24gdGhlIHdpa2kgd2l0
aCB0aGlzIGluZm9ybWF0aW9uLiBBbm90aGVyIHdheSBpcyB0byB1c2UgYSANCkdpdEh1YiBD
T0RFT1dORVJTIGZpbGUsW14xXSB3aGljaCB0YWtlcyBjYXJlIG9mIHJlcXVlc3RpbmcgdGhl
IHJldmlld3MgDQphdXRvbWF0aWNhbGx5Lg0KDQpJJ3ZlIG9wZW5lZCBhIGRyYWZ0IFBSIHRv
IGRpc2N1c3MgdGhlIENPREVPV05FUlMgZmlsZSBhcHByb2FjaDogDQpodHRwczovL2dpdGh1
Yi5jb20vcGhwL3BocC1zcmMvcHVsbC84NjcwDQoNCkkgZG9uJ3Qga25vdyBob3cgZmVhc2li
bGUgaXQgaXMgdG8gbWFpbnRhaW4gYSBsaXN0IGxpa2UgdGhpcyBmb3IgdGhlIFBIUCANCnBy
b2plY3QuIElkZWFsbHksIGZvbGtzIHdvdWxkIGFkZCB0aGVtc2VsdmVzIHRvIHRoZSBsaXN0
IGFuZCANCnNlbGYtaWRlbnRpZnkgd2hpY2ggYXJlYXMgb2YgdGhlIGNvZGUgYmFzZSB0aGV5
IHdhbnQgdG8gaGF2ZSANCmF1dG9tYXRpY2FsbHkgcmVxdWVzdCB0aGVtIGZvciByZXZpZXdz
Lg0KDQpXaGF0IGRvIG90aGVycyB0aGluaz8NCg0KLS0gDQpDaGVlcnMsDQpCZW4NCg0KDQpb
XjFdOiANCmh0dHBzOi8vZG9jcy5naXRodWIuY29tL2VuL3JlcG9zaXRvcmllcy9tYW5hZ2lu
Zy15b3VyLXJlcG9zaXRvcnlzLXNldHRpbmdzLWFuZC1mZWF0dXJlcy9jdXN0b21pemluZy15
b3VyLXJlcG9zaXRvcnkvYWJvdXQtY29kZS1vd25lcnMNCg==

--------------5B4dG9Q95NjpB6bvWTSB00s7--
  117844
June 1, 2022 09:07 cmbecker69@gmx.de ("Christoph M. Becker")
On 31.05.2022 at 23:53, Ben Ramsey wrote:

> This came up in a conversation I had with Sergey and Pierrick earlier > today... > > As release managers go through open PRs, we tag them with "Waiting on > Review" to indicate to other internals devs that a PR needs review. > > In fact, we have quite a few that are currently waiting on review: > > https://github.com/php/php-src/pulls?q=is%3Aopen+is%3Apr+label%3A%22Waiting+on+Review%22 > > > Unfortunately, we don't always know who is the best person to review a > PR, so we hope that others are checking to see whether there are PRs > that need reviews in their area of expertise. > > It would be helpful to know from whom we should request reviews, based > on the area of the code (i.e., ext, Zend, main, etc.). One way is to set > up a table on the wiki with this information. Another way is to use a > GitHub CODEOWNERS file,[^1] which takes care of requesting the reviews > automatically. > > I've opened a draft PR to discuss the CODEOWNERS file approach: > https://github.com/php/php-src/pull/8670 > > I don't know how feasible it is to maintain a list like this for the PHP > project. Ideally, folks would add themselves to the list and > self-identify which areas of the code base they want to have > automatically request them for reviews. > > What do others think?
FWIW, there is already EXTENSIONS[1]. There even was an RFC about that[2] some years ago, but in hindsight, that didn't work out. One of the problems is that we cannot unbundle some extensions even if they have no maintainer (e.g. Spl). And it is not likely, that someone steps up as maintainer of such extensions; it's more likely that several contributors will occassionally have a look at issues regarding such extensions. So I doubt that a CODEOWNERS file will be of much use. [1] <https://github.com/php/php-src/blob/master/EXTENSIONS> [2] <https://wiki.php.net/rfc/umaintained_extensions> -- Christoph M. Becker
  117845
June 1, 2022 12:22 landers.robert@gmail.com (Robert Landers)
On Wed, Jun 1, 2022 at 11:07 AM Christoph M. Becker <cmbecker69@gmx.de> wrote:
> > On 31.05.2022 at 23:53, Ben Ramsey wrote: > > > This came up in a conversation I had with Sergey and Pierrick earlier > > today... > > > > As release managers go through open PRs, we tag them with "Waiting on > > Review" to indicate to other internals devs that a PR needs review. > > > > In fact, we have quite a few that are currently waiting on review: > > > > https://github.com/php/php-src/pulls?q=is%3Aopen+is%3Apr+label%3A%22Waiting+on+Review%22 > > > > > > Unfortunately, we don't always know who is the best person to review a > > PR, so we hope that others are checking to see whether there are PRs > > that need reviews in their area of expertise. > > > > It would be helpful to know from whom we should request reviews, based > > on the area of the code (i.e., ext, Zend, main, etc.). One way is to set > > up a table on the wiki with this information. Another way is to use a > > GitHub CODEOWNERS file,[^1] which takes care of requesting the reviews > > automatically. > > > > I've opened a draft PR to discuss the CODEOWNERS file approach: > > https://github.com/php/php-src/pull/8670 > > > > I don't know how feasible it is to maintain a list like this for the PHP > > project. Ideally, folks would add themselves to the list and > > self-identify which areas of the code base they want to have > > automatically request them for reviews. > > > > What do others think? > > FWIW, there is already EXTENSIONS[1]. There even was an RFC about > that[2] some years ago, but in hindsight, that didn't work out. One of > the problems is that we cannot unbundle some extensions even if they > have no maintainer (e.g. Spl). And it is not likely, that someone steps > up as maintainer of such extensions; it's more likely that several > contributors will occassionally have a look at issues regarding such > extensions. > > So I doubt that a CODEOWNERS file will be of much use. > > [1] <https://github.com/php/php-src/blob/master/EXTENSIONS> > [2] <https://wiki.php.net/rfc/umaintained_extensions> > > -- > Christoph M. Becker > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: https://www.php.net/unsub.php >
> So I doubt that a CODEOWNERS file will be of much use.
It is not necessary that the owners file covers every file in the repo. But for aspects of the code that do have an owner, having an owner file makes things much simpler.