Feedback on bugfix for streamed fcgi requests (#51191)

  116490
November 24, 2021 08:05 tim.siebels@iserv.eu (Tim Siebels)
Hi everybody,

I've submitted a pull-request to fix bug #51191. This is now waiting for
review for 2 months. Is there anything further I can do? What's the
appropriate duration to wait before pinging at this mailinglist?

Link to PR: https://github.com/php/php-src/pull/7509

I've just rebased to fix merge conflicts. CI is failing due to an error
on azure regarding purchased parallelism. I guess this will resolve
itself once this is fixed.

Cheers,
Tim
  116491
November 24, 2021 09:08 bukka@php.net (Jakub Zelenka)
On Wed, Nov 24, 2021 at 8:06 AM Tim Siebels siebels@iserv.eu> wrote:

> Hi everybody, > > I've submitted a pull-request to fix bug #51191. This is now waiting for > review for 2 months. Is there anything further I can do? What's the > appropriate duration to wait before pinging at this mailinglist? > > Link to PR: https://github.com/php/php-src/pull/7509 > > I've just rebased to fix merge conflicts. CI is failing due to an error > on azure regarding purchased parallelism. I guess this will resolve > itself once this is fixed. > > Sorry I have been busy with that security issue in FPM which was a higher
priority. The PR seems ready but need to think about the actual change a bit more. It's at least on my list now so should get resolved soon hopefully. Thanks Jakub
  116492
November 24, 2021 09:12 tim.siebels@iserv.eu (Tim Siebels)
Hi,

No worries. Thanks for the quick reply!

On 24.11.21 10:08, Jakub Zelenka wrote:
> On Wed, Nov 24, 2021 at 8:06 AM Tim Siebels siebels@iserv.eu> wrote: > >> Hi everybody, >> >> I've submitted a pull-request to fix bug #51191. This is now waiting for >> review for 2 months. Is there anything further I can do? What's the >> appropriate duration to wait before pinging at this mailinglist? >> >> Link to PR: https://github.com/php/php-src/pull/7509 >> >> I've just rebased to fix merge conflicts. CI is failing due to an error >> on azure regarding purchased parallelism. I guess this will resolve >> itself once this is fixed. >> >> > Sorry I have been busy with that security issue in FPM which was a higher > priority. The PR seems ready but need to think about the actual change a > bit more. It's at least on my list now so should get resolved soon > hopefully. > > Thanks > > Jakub >