Re: [PHP-CVS] com php-src: Consolidate Parameter Names For ext/simplexml: ext/simplexml/simplexml.stub.php ext/simplexml/simplexml_arginfo.h

This is only part of a thread. view whole thread
July 27, 2020 22:53 derick@php.net (Derick Rethans)
On 27 July 2020 20:42:33 BST, Benjamin Eberlei <beberlei@php.net> wrote:
>Commit: eaeceb32932026c08a9d9e5be56da8e8111c5caa >Author: Benjamin Eberlei <kontakt@beberlei.de> Mon, 27 Jul >2020 19:32:00 +0200 >Parents: 8a6bc6767dbda4861b83fb9dcbba4453e541bbb9 >Branches: master > >Link: >http://git.php.net/?p=php-src.git;a=commitdiff;h=eaeceb32932026c08a9d9e5be56da8e8111c5caa > >Log: >Consolidate Parameter Names For ext/simplexml > >Co-authored-by: Thomas Weinert <thomas@weinert.info> > >Changed paths: > M ext/simplexml/simplexml.stub.php > M ext/simplexml/simplexml_arginfo.h > > >Diff: >diff --git a/ext/simplexml/simplexml.stub.php >b/ext/simplexml/simplexml.stub.php >index 2922adce4b..d3e48b0e6a 100644 >--- a/ext/simplexml/simplexml.stub.php >+++ b/ext/simplexml/simplexml.stub.php >@@ -2,19 +2,19 @@ > > /** @generate-function-entries */ > >-function simplexml_load_file(string $filename, ?string $class_name = >SimpleXMLElement::class, int $options = 0, string $ns = '', bool >$is_prefix = false): SimpleXMLElement|false {} >+function simplexml_load_file(string $filename, ?string $class_name = >SimpleXMLElement::class, int $options = 0, string $namespace_or_prefix >= '', bool $is_prefix = false): SimpleXMLElement|false {}
I thought we were using studlyCaps, so that should be isPrefix and namespaceOrPrefix? cheers, Derick