Hello, internals team!
I would like to propose to rename the PhpToken::getAll() method into the
PhpToken::tokenize(string $source) or PhpToken::lex(string $source) to use
a more meaningful verb word.
After renaming, it will sound more natural: $tokenStream =
Ð¿Ð½, 23 Ð¼Ð°Ñ. 2020 Ð³. Ð² 19:04, Larry Garfield <email@example.com>:
> On Mon, Mar 23, 2020, at 9:07 AM, Nikita Popov wrote:
> > On Fri, Mar 6, 2020 at 10:33 AM Nikita Popov firstname.lastname@example.org>
> > > Hi internals,
> > >
> > > I've opened voting on https://wiki.php.net/rfc/token_as_object, which
> > > adds a new object-based interface to the tokenizer. Voting closes on
> > > 2020-03-20.
> > >
> > This RFC has been accepted unanimously, with 47 votes in favor.
> > Based on the additional feedback in this thread, I'll also add a
> > __toString() method that returns the value of $token->text, unless anyone
> > has objects to that...
> > Regards,
> > Nikita
> As long as __toString() is overridable in subclasses, that seems fine to
> --Larry Garfield
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php