[VOTE] Stringable

  108509
February 12, 2020 14:37 nicolas.grekas+php@gmail.com (Nicolas Grekas)
Hi everyone,

I happy to open the vote for the Stringable RFC:
https://wiki.php.net/rfc/stringable#vote

The vote will stay open until 2020-02-26.

Cheers,
Nicolas
  108780
February 27, 2020 08:49 nicolas.grekas+php@gmail.com (Nicolas Grekas)
Hello everyone,

I happy to open the vote for the Stringable RFC:
> https://wiki.php.net/rfc/stringable#vote > > The vote will stay open until 2020-02-26. >
The proposal has been accepted with 29 "Yes" votes and 9 "No. The vote is now closed, the RFC page updated and the PR on GitHub is ready to merge. Thank you! Nicolas
  108818
March 3, 2020 09:54 nikita.ppv@gmail.com (Nikita Popov)
On Thu, Feb 27, 2020 at 9:49 AM Nicolas Grekas grekas+php@gmail.com>
wrote:

> Hello everyone, > > I happy to open the vote for the Stringable RFC: > > https://wiki.php.net/rfc/stringable#vote > > > > The vote will stay open until 2020-02-26. > > > > The proposal has been accepted with 29 "Yes" votes and 9 "No. > > The vote is now closed, the RFC page updated and the PR on GitHub is ready > to merge. > > Thank you! > > Nicolas >
Ironically, this broke Symfony ;)
> Fatal error: Access level to class@anonymous::__toString() must be public (as in class Stringable) in
/home/vsts/work/1/s/symfony/src/Symfony/Component/String/Tests/LazyStringTest.php(110) : eval()'d code on line 1 But it seems that this was already a warning before:
> Warning: The magic method __toString() must have public visibility and cannot be static in /in/3m4Za on line 4
So it doesn't seem like a big issue in practice. Nikita
  108820
March 3, 2020 10:09 nicolas.grekas+php@gmail.com (Nicolas Grekas)
> > Ironically, this broke Symfony ;) > > > Fatal error: Access level to class@anonymous::__toString() must be > public (as in class Stringable) in > /home/vsts/work/1/s/symfony/src/Symfony/Component/String/Tests/LazyStringTest.php(110) > : eval()'d code on line 1 > > > Indeed!
Fixed in https://github.com/symfony/symfony/pull/35935 But it seems that this was already a warning before:
> > > Warning: The magic method __toString() must have public visibility and > cannot be static in /in/3m4Za on line 4 > > So it doesn't seem like a big issue in practice. >
I agree :)