Re: php 7.{3,4}/git ext/curl builds FAIL with recent curl/libcurl 7.67+: "error: ‘CURLE_OBSOLETE20’ undeclared ...".

This is only part of a thread. view whole thread
  107794
November 15, 2019 08:18 cmbecker69@gmx.de ("Christoph M. Becker")
On 15.11.2019 at 05:56, PGNet Dev wrote:

> I needed to bump local curl build version to fix a (php-unrelated) SEGV. Currently, I have > > curl -V > curl 7.67.1-DEV (x86_64-pc-linux-gnu) libcurl/7.67.1-DEV OpenSSL/1.1.1d zlib/1.2.11 brotli/1.0.7 libidn2/2.2.0 libpsl/0.21.0 (+libidn2/2.2.0) libssh2/1.9.0_DEV nghttp2/1.40.0-DEV > Release-Date: [unreleased] > Protocols: dict file ftp ftps http https imap imaps pop3 pop3s scp sftp smtp smtps tftp > Features: AsynchDNS brotli HTTP2 HTTPS-proxy IDN IPv6 Largefile libz Metalink NTLM NTLM_WB PSL SSL TLS-SRP UnixSockets > > Rebuilding my usual PHP7.3/git install, > (add'l note: fwiw, the following issue also occurs with 7.4/git ...) > > cd php7 > > git branch -a | grep \* > * PHP-7.3 > > git log | head > commit 9083e178f656878cab46aee52b555346ef92a768 > Author: Dmitry Stogov <dmitry@zend.com> > Date: Tue Nov 12 12:59:50 2019 +0300 > > Fixed wrong constant usage > > commit ea2a125789d2e6cf7416bd706be1ac44df1367e4 > Merge: 4a55794b98 2c9926f156 > Author: Stanislav Malyshev <stas@php.net> > Date: Mon Nov 11 23:08:38 2019 -0800 > > works nicely as usual, > > /usr/local/php7/bin/php -v > PHP 7.3.13-dev (cli) (built: Nov 14 2019 19:53:24) ( NTS ) > Copyright (c) 1997-2018 The PHP Group > Zend Engine v3.3.13-dev, Copyright (c) 1998-2018 Zend Technologies > with Zend OPcache v7.3.13-dev, Copyright (c) 1999-2018, by Zend Technologies > > But curl extension now fails, > > ext/curl/interface.c:778:25: error: ‘CURLE_OBSOLETE20’ undeclared (first use in this function); did you mean ‘CURLE_OBSOLETE50’? > 778 | REGISTER_CURL_CONSTANT(CURLE_FTP_WRITE_ERROR); > > > Before making noise about in @bugs, wanted to check 1st; known issue? additional/new config req'd?
That appears to be due to a recent change in libcurl[1]. We'll have to work around that, but I'm not sure how. Define both constants for BC? [1] <https://github.com/curl/curl/blob/b3eb7d172aab6c7f423aea2f97c27099d6b65f7a/include/curl/curl.h#L504-L506> -- Christoph M. Becker
  107795
November 15, 2019 09:01 rowan.collins@gmail.com (Rowan Tommins)
On Fri, 15 Nov 2019 at 08:19, Christoph M. Becker <cmbecker69@gmx.de> wrote:

> > That appears to be due to a recent change in libcurl[1]. We'll have to > work around that, but I'm not sure how. Define both constants for BC? > > [1] > < > https://github.com/curl/curl/blob/b3eb7d172aab6c7f423aea2f97c27099d6b65f7a/include/curl/curl.h#L504-L506 > > >
It looks like last time this happened (value 16 reused for HTTP2), the removed constant was reintroduced in curl to avoid just this scenario: https://github.com/curl/curl/pull/106 Perhaps a patch should be submitted to do the same thing again this time? Regards, -- Rowan Tommins [IMSoP]
  107796
November 15, 2019 09:41 cmbecker69@gmx.de ("Christoph M. Becker")
On 15.11.2019 at 10:01, Rowan Tommins wrote:

> On Fri, 15 Nov 2019 at 08:19, Christoph M. Becker <cmbecker69@gmx.de> wrote: > >> That appears to be due to a recent change in libcurl[1]. We'll have to >> work around that, but I'm not sure how. Define both constants for BC? >> >> [1] <https://github.com/curl/curl/blob/b3eb7d172aab6c7f423aea2f97c27099d6b65f7a/include/curl/curl.h#L504-L506> >> It looks like last time this happened (value 16 reused for HTTP2), the > removed constant was reintroduced in curl to avoid just this scenario: > https://github.com/curl/curl/pull/106 > > Perhaps a patch should be submitted to do the same thing again this time?
Ah, thanks! I've just submitted <https://github.com/curl/curl/pull/4601>. -- Christoph M. Becker
  107800
November 15, 2019 16:15 pgnet.dev@gmail.com (PGNet Dev)
On 11/15/19 1:41 AM, Christoph M. Becker wrote:
> Ah, thanks! I've just submitted <https://github.com/curl/curl/pull/4601>.
applied that patch to local curl/master build now build of php7/ext/curl .... make
>> Build complete.
thx!
  107850
November 22, 2019 01:30 pgnet.dev@gmail.com (PGNet Dev)
On 11/15/19 8:15 AM, PGNet Dev wrote:
> On 11/15/19 1:41 AM, Christoph M. Becker wrote: >> Ah, thanks! I've just submitted <https://github.com/curl/curl/pull/4601>. > > applied that patch to local curl/master build > > now build of php7/ext/curl
fyi, bumps to php 7.4/git git log | head commit 99b8e67615159fc600a615e1e97f2d1cf18f14cb Merge: b78ec58f09 e981f5af51 Author: George Wang <gwang@php.net> Date: Thu Nov 21 17:58:44 2019 -0500 Merge branch 'PHP-7.3' into PHP-7.4 commit e981f5af51bf2a16965aad68ae268021dc251c9c Merge: b4f501d5a4 c7141412ce Author: George Wang <gwang@php.net> and curl/master, git log | head commit f70da9c17e315f382694d8ca5585191f4e5478d7 Author: Daniel Stenberg <daniel@haxx.se> Date: Thu Nov 21 11:37:44 2019 +0100 include: make CURLE_HTTP3 use a new error code To avoid potential issues with error code reuse. Reported-by: Christoph M. Becker Assisted-by: Dan Fandrich which includes the reworked fix for this issue, https://github.com/curl/curl/commit/f70da9c17e315f382694d8ca5585191f4e5478d7 does the trick as well, php -v PHP 7.4.1-dev (cli) (built: Nov 21 2019 16:45:24) ( NTS ) Copyright (c) The PHP Group Zend Engine v3.4.0, Copyright (c) Zend Technologies with Zend OPcache v7.4.1-dev, Copyright (c), by Zend Technologies php -m | grep curl curl now just a matter of the fix making it into next curl release.