Re: [PHP-DEV] Using [ci skip]

This is only part of a thread. view whole thread
  105860
June 7, 2019 14:07 krakjoe@gmail.com (Joe Watkins)
Hi Peter,

I think it's pretty well known about, but don't think we have it written
down anywhere. I could make a note of it somewhere.

I think in the case of azure it can be configured but I'm not sure about
the others. I'll try to find out.

Cheers
Joe

On Fri, 7 Jun 2019 at 16:00, Peter Cowburn <petercowburn@gmail.com> wrote:

> > > On Fri, 7 Jun 2019 at 12:09, Joe Watkins <krakjoe@gmail.com> wrote: > >> Oh to be absolutely clear, I'm talking about commits that *only* touch >> these non-source files ... >> >> Cheers >> Joe >> >> On Fri, 7 Jun 2019 at 13:07, Joe Watkins <krakjoe@gmail.com> wrote: >> >> > Hi Marco, >> > >> > It wasn't a topic for discussion, it was a request to committers in >> > php-src. >> > >> > We do not need to run CI for NEWS changes, and we can definitely be sure >> > it doesn't effect the build. >> > >> > The same goes for other files like UPGRADING, UPGRADING.INTERNALS ... >> > >> > Under normal circumstances these files are not changed by themslves, but >> > occasionally, we have to correct one of these files and omitting [ci >> ski] >> > puts the build behind by up to an hour ... >> > >> > Cheers >> > Joe >> > >> > On Fri, 7 Jun 2019 at 13:02, Marco Pivetta <ocramius@gmail.com> wrote: >> > >> >> Please avoid doing that: >> >> >> >> 1. Commit messages are for humans >> >> 2. You never know what can break, that's why it's "continuous" there >> >> (besides religious views around what "continuous integration" means) >> >> >> >> On Fri, Jun 7, 2019, 12:51 Joe Watkins <krakjoe@php.net> wrote: >> >> >> >> > Hi all, >> >> > >> >> > Just a friendly reminder that when we're committing changes to files >> >> that >> >> > do not contain source, test code, or build configuration, it's >> helpful >> >> to >> >> > include [ci skip] in the commit message. Omitting it can put our CI >> >> quite >> >> > far behind. >> > > Is this documented somewhere? I'm not seeing it in the docs held in > php-src, nor a search of the wiki, for example. > Also, is this not something that the CI application(s) can be configured > to do for us? > > >> >> > >> >> > Cheers >> >> > Joe >> >> > >> >> >> > >> >
  105875
June 12, 2019 01:31 scott@exussum.co.uk (Scott Dutton)
Hi Joe

Is there any reason why something like the following isnt run instead ?

runTests=$(git diff origin/master... --name-only --diff-filter=ACMR -- 
':(exclude)docs/*' | wc -l)

if [[ "${runTests}" -gt 0 ]]; then
     ./run-tests.sh
fi
~


Which says if the diff contains files outside of /docs then run the 
tests.

Contributors can then forget about the [ci-skip] and gets the same 
effect

This runs on linux but I cant imagine its a big change to make for this 
to work on windows ?

You can tweak the diff command to only run tests when certain sets of 
files change

Thanks

Scott

On 07.06.2019 15:07, Joe Watkins wrote:
> Hi Peter, > > I think it's pretty well known about, but don't think we have it > written > down anywhere. I could make a note of it somewhere. > > I think in the case of azure it can be configured but I'm not sure > about > the others. I'll try to find out. > > Cheers > Joe > > On Fri, 7 Jun 2019 at 16:00, Peter Cowburn <petercowburn@gmail.com> > wrote: > >> >> >> On Fri, 7 Jun 2019 at 12:09, Joe Watkins <krakjoe@gmail.com> wrote: >> >>> Oh to be absolutely clear, I'm talking about commits that *only* >>> touch >>> these non-source files ... >>> >>> Cheers >>> Joe >>> >>> On Fri, 7 Jun 2019 at 13:07, Joe Watkins <krakjoe@gmail.com> wrote: >>> >>> > Hi Marco, >>> > >>> > It wasn't a topic for discussion, it was a request to committers >>> in >>> > php-src. >>> > >>> > We do not need to run CI for NEWS changes, and we can definitely >>> be sure >>> > it doesn't effect the build. >>> > >>> > The same goes for other files like UPGRADING, UPGRADING.INTERNALS >>> ... >>> > >>> > Under normal circumstances these files are not changed by >>> themslves, but >>> > occasionally, we have to correct one of these files and omitting >>> [ci >>> ski] >>> > puts the build behind by up to an hour ... >>> > >>> > Cheers >>> > Joe >>> > >>> > On Fri, 7 Jun 2019 at 13:02, Marco Pivetta <ocramius@gmail.com> >>> wrote: >>> > >>> >> Please avoid doing that: >>> >> >>> >> 1. Commit messages are for humans >>> >> 2. You never know what can break, that's why it's "continuous" >>> there >>> >> (besides religious views around what "continuous integration" >>> means) >>> >> >>> >> On Fri, Jun 7, 2019, 12:51 Joe Watkins <krakjoe@php.net> wrote: >>> >> >>> >> > Hi all, >>> >> > >>> >> > Just a friendly reminder that when we're committing changes to >>> files >>> >> that >>> >> > do not contain source, test code, or build configuration, it's >>> helpful >>> >> to >>> >> > include [ci skip] in the commit message. Omitting it can put >>> our CI >>> >> quite >>> >> > far behind. >>> >> >> Is this documented somewhere? I'm not seeing it in the docs held in >> php-src, nor a search of the wiki, for example. >> Also, is this not something that the CI application(s) can be >> configured >> to do for us? >> >> >>> >> > >>> >> > Cheers >>> >> > Joe >>> >> > >>> >> >>> > >>> >>