Expose gmp_ce and friends

  100809
October 2, 2017 21:33 pollita@php.net (Sara Golemon)
Stas specifically, but also others:

Any objections if I apply
https://github.com/php/php-src/compare/master...sgolemon:gmp.export to
make consuming GMP objects from third-party extensions easier?

-Sara
  100823
October 4, 2017 21:32 kalle@php.net (Kalle Sommer Nielsen)
Hi Sara

2017-10-02 23:33 GMT+02:00 Sara Golemon <pollita@php.net>:
> Stas specifically, but also others: > > Any objections if I apply > https://github.com/php/php-src/compare/master...sgolemon:gmp.export to > make consuming GMP objects from third-party extensions easier?
+1, only note I have is that with the change to config.m4, a relevant one should maybe also follow for phpize on Windows for config.w32 -- regards, Kalle Sommer Nielsen kalle@php.net
  100825
October 5, 2017 12:50 johannes@schlueters.de (Johannes =?ISO-8859-1?Q?Schl=FCter?=)
On Mo, 2017-10-02 at 17:33 -0400, Sara Golemon wrote:
> Stas specifically, but also others: > > Any objections if I apply > https://github.com/php/php-src/compare/master...sgolemon:gmp.export > to > make consuming GMP objects from third-party extensions easier? > > -Sara
I would prefer not exporting the php_gmp.h, but a gmp.h (or similar) and let php_gmp.h there for main/builtin_functions.c only. If a consumer wants access to the module_entry they can query EG(modules) and other declarations in there should be "private". johannes
  100828
October 5, 2017 15:28 pollita@php.net (Sara Golemon)
On Thu, Oct 5, 2017 at 8:50 AM, Johannes Schlüter
<johannes@schlueters.de> wrote:
> I would prefer not exporting the php_gmp.h, but a gmp.h (or similar) > and let php_gmp.h there for main/builtin_functions.c only. If a > consumer wants access to the module_entry they can query EG(modules) > and other declarations in there should be "private". > Yeah, I shouldn't be lazy. I should do things right.
On Wed, Oct 4, 2017 at 5:32 PM, Kalle Sommer Nielsen <kalle@php.net> wrote: > +1, only note I have is that with the change to config.m4, a relevant
> one should maybe also follow for phpize on Windows for config.w32 > Ugh, windows... is that still a thing?